Adds Vim 8 terminal highlighting

[c9rgreen]

Resolves #125

[kooparse]

I tried it, but it seems that the color don't really match the iTerm or the neovim one.

With Vim 8:

On iTerm:

But it is perhaps my config... :)

[c9rgreen]

@kooparse Can you confirm that you were running Vim 8 in iTerm using the cg433n/nord-vim fork of nord-vim?

[kooparse]

@cg433n Yes I can confirm that :)

vim 8.1 on the left and neovim on the right.

[delphinus]

In my env, Vim shows valid colors in terminal. Perhaps your vimrc makes a problem?

my reproducible way

• iTerm2 Build 3.2.0beta6
• MacVim 8.1-149

mkdir /tmp/nord-vim
cd /tmp/nord-vim
git clone https://github.com/cg433n/nord-vim
vim -N -u vimrc -i NONE

/tmp/nord-vim/vimrc

set runtimepath+=/tmp/nord-vim/nord-vim
colorscheme nord

[kooparse]

It is my config, we should merge it then 👍

[c9rgreen]

I've tested with Vim 8 and iTerm and Terminal.app. Everything looks Ok.

[arcticicestudio]

@cg433n Thanks for this PR and also everyone else involved for the feedback 👍

The changes looking good to me, I'll do a quick test on the weekend and merge it to get the next release version out asap.

[jbadavis]

Hey @arcticicestudio, could this be merged?

[arcticicestudio]

@jbadavis Sorry, this is one of the hundreds issues I've planned to review earlier, but sometimes real life keeps you busy. I'll set a reminder and will definitely do it this weekend.

[arcticicestudio]

I've tested it with

• Vim v8.1 on macOS (Homebrew) and v8.1.0751-1 on Arch Linux
• NeoVim v0.3.4 on macOS (Homebrew) and Arch Linux
• MacVim v8.1-153 on macOS (Homebrew)

using a clean config and everything looks fine.
I'll merge it and if there are any problems or incompatibilities please open a new issue.

[sivakov512]

Hey @arcticicestudio, could this be merged?

[arcticicestudio]

@sivakov512 I've reviewed the PR and requested some changes. It'll be merged as soon as the PR author resolved them.

[arcticicestudio]

@cg433n Thanks for updating, but I've never used the "Suggested Changes" feature of GitHub so I've messed it up 😆
Fixed it again and force-pushed to merge.

Thanks again for your contribution 🚀

[arcticicestudio]

When using vim-plug the latest changes can be used by defining the develop branch as plugin origin.