Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LSP textDocument/documentHighlight #284

Merged

Conversation

cmoscofian
Copy link
Contributor

Allows nord to properly handle the highlight groups associated with the
method textDocument/documentHightlight in neovim.

See it in action:
Screen Recording 2022-01-02 at 17 50 35

Allows nord to properly handle the highlight groups associated with the
method textDocument/documentHightlight in neovim.
@arcticicestudio
Copy link
Contributor

Hi @cmoscofian 👋, thanks for your contribution 👍
I'll try to test and review the changes within the next week(s).

The implementation of the LspReference highlight groups should not be
under the 0.5 check as it was not subjected to any deprecation.
Copy link
Contributor

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks again 🚀

@arcticicestudio
Copy link
Contributor

Release note & changelog assets

gh-284.mp4

@arcticicestudio arcticicestudio merged commit 3e4e273 into nordtheme:develop Jan 12, 2022
@arcticicestudio arcticicestudio added this to the Next milestone Jan 12, 2022
@cmoscofian cmoscofian deleted the enhancement/lsp-reference-support branch January 12, 2022 22:19
jcypret pushed a commit to jcypret/nord-vim-midnight that referenced this pull request Feb 19, 2022
Support for Neovim LSP `documentHighlight` groups

The Neovim LSP `textDocument` / `documentHightlight` groups [1] are
responsible to highlight tokens in a document that are related to each
other, e.g. decalred variables, using the
`vim.buf.lsp.document_highlight()` function.
Also see the LSP specification about "Document Highlights Request" [2]
for more details.

[1]: https://github.com/neovim/neovim/blob/f92a2457c2e7ad14d9a5a907ef4213fa770b6d95/runtime/doc/lsp.txt#L423
[2]: https://microsoft.github.io/language-server-protocol/specification#textDocument_documentHighlight


Co-authored-by: Arctic Ice Studio <[email protected]>
Co-authored-by: Sven Greb <[email protected]>
crispgm added a commit to crispgm/nord-vim that referenced this pull request Apr 2, 2022
arcticicestudio added a commit that referenced this pull request May 14, 2022
Support for Neovim LSP `documentHighlight` groups

The Neovim LSP `textDocument` / `documentHightlight` groups [1] are
responsible to highlight tokens in a document that are related to each
other, e.g. decalred variables, using the
`vim.buf.lsp.document_highlight()` function.
Also see the LSP specification about "Document Highlights Request" [2]
for more details.

[1]: https://github.com/neovim/neovim/blob/f92a2457c2e7ad14d9a5a907ef4213fa770b6d95/runtime/doc/lsp.txt#L423
[2]: https://microsoft.github.io/language-server-protocol/specification#textDocument_documentHighlight


Co-authored-by: Arctic Ice Studio <[email protected]>
Co-authored-by: Sven Greb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants