Don't load plugin-related things when the relevant plugin isn't installed #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lled Function calls are expensive in vim-script. This commit speeds up the processing of colors/nord.vim in neovim 0.6.1 by almost 50% on my machine, where none of the supported plugins are installed.
|
Hi @jvoisin 👋, thanks for your contribution 👍 |
The Neovim terminal colors and some plugins are exclusively for Neovim so they can be warpped in a `nvim` conditional block too. GH-294
svengreb
approved these changes
Apr 10, 2022
There was a problem hiding this comment.
Only loading the highlighting groups conditionally makes sense and reducing overhead, and therefore improving the performance, is always good 😄
I've also moved some other Neovim exclusive features & plugins into a nvim block guard even though they will be deprecated and removed from this port when the official Neovim port is available in a stable version.
Thanks again for the contribution 🤘🏼
arcticicestudio
approved these changes
Apr 10, 2022
svengreb
added a commit
that referenced
this pull request
Apr 11, 2022
This commit is a continuation of GH-294, see message and PR discussion of commit `a4bf0a63e8e1e62e884eee9ec04d577105f58aa7` for details. [1]: a4bf0a6 Related to GH-294 GH-296 Co-authored-by: Julien Voisin <[email protected]> Co-authored-by: Sven Greb <[email protected]>
|
I get in |
|
#301 should fix it, sorry about breaking things :/ |
|
No problem, thanks for fixing it :) |
|
@alappe Thanks for the report, this has been fixed in #297. Also see my comment in the PR about what can be learned from this. |
arcticicestudio
pushed a commit
that referenced
this pull request
Apr 23, 2022
The changes introduced in PR GH-294 [1] did not take into account that the order how plugins are loaded are not always constant and can also change based on how users order plugins in their configurations. When a supported plugin is loaded after Nord the global `loaded_*` variable might not be available yet, causing the styles to be skipped due to the conditional block guard. Also each plugin manager handles the plugin loading order differently which is also a problem when checking for global variable existence. [1]: #294 [2]: #306 Fixes GH-306
svengreb
added a commit
that referenced
this pull request
Apr 23, 2022
The changes introduced in PR GH-294 [1] did not take into account that the order how plugins are loaded are not always constant and can also change based on how users order plugins in their configurations. When a supported plugin is loaded after Nord the global `loaded_*` variable might not be available yet, causing the styles to be skipped due to the conditional block guard. Also each plugin manager handles the plugin loading order differently which is also a problem when checking for global variable existence. The loading time of the Nord plugin is still totally fine so improving the stability for only a minimal performance boost is no negative trade at all (tested via `vim --startuptime timing.out`): 4.956ms: sourcing ~/.local/share/vim/plugged/nord-vim/colors/nord.vim [1]: #294 [2]: #306 Fixes GH-306
arcticicestudio
pushed a commit
that referenced
this pull request
May 14, 2022
…lled (#294) Guard plugin and Neovim specific features in conditional blocks Function calls are expensive in Vim script so to reduce the overhead of processing the theme most plugin and Neovim specific features are now wrapped in conditional blocks, e.g. Neovim highlighting groups are only loaded when the global `nvim` variable is set while other plugins are checked for their own `loaded_*` variable (common plugin pattern). Some plugins provide no easy/straightforward way to be detected, so not all blocks are behind conditions, but it's still a significant improvement, and can always be improved in the future. Co-authored-by: Julien Voisin <[email protected]> Co-authored-by: Sven Greb <[email protected]> GH-294
arcticicestudio
pushed a commit
that referenced
this pull request
May 14, 2022
This commit is a continuation of GH-294, see message and PR discussion of commit `a4bf0a63e8e1e62e884eee9ec04d577105f58aa7` for details. [1]: a4bf0a6 Related to GH-294 GH-296 Co-authored-by: Julien Voisin <[email protected]> Co-authored-by: Sven Greb <[email protected]>
arcticicestudio
pushed a commit
that referenced
this pull request
May 14, 2022
The changes introduced in PR GH-294 [1] did not take into account that the order how plugins are loaded are not always constant and can also change based on how users order plugins in their configurations. When a supported plugin is loaded after Nord the global `loaded_*` variable might not be available yet, causing the styles to be skipped due to the conditional block guard. Also each plugin manager handles the plugin loading order differently which is also a problem when checking for global variable existence. The loading time of the Nord plugin is still totally fine so improving the stability for only a minimal performance boost is no negative trade at all (tested via `vim --startuptime timing.out`): 4.956ms: sourcing ~/.local/share/vim/plugged/nord-vim/colors/nord.vim [1]: #294 [2]: #306 Fixes GH-306
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function calls are expensive in vim-script.
This commit speeds up the processing of colors/nord.vim
in neovim 0.6.1 by almost 50% on my machine, where
none of the supported plugins are installed.
Some plugins provide no easy/straightforward way to be detected, so not all blocks are behind conditions, but it's still a significant improvement, and can always be improved in the future.