Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use one more ternary #305

Merged
merged 1 commit into from
Apr 24, 2022
Merged

Use one more ternary #305

merged 1 commit into from
Apr 24, 2022

Conversation

jvoisin
Copy link
Contributor

@jvoisin jvoisin commented Apr 16, 2022

No description provided.

@svengreb svengreb added this to the version-next milestone Apr 24, 2022
svengreb
svengreb approved these changes Apr 24, 2022
View reviewed changes
Copy link
Member

@svengreb svengreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jvoisin 👋, thanks for your contribution 👍
Again a good simplification 👍🏼

@svengreb svengreb merged commit e3eb208 into nordtheme:develop Apr 24, 2022
arcticicestudio pushed a commit that referenced this pull request May 14, 2022
@jvoisin @svengreb
Use ternary for "italic" theme configuration (#305)
dd7666d 
Instead of using a if/else block and empty variable declaration Vim's
builtin `get` function [1] is now used to simplify the code.


Co-authored-by: Sven Greb <[email protected]>
Co-authored-by: Arctic Ice Studio <[email protected]>

[1]: https://vimhelp.org/builtin.txt.html#builtin.txt#get%28%29

GH-305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svengreb svengreb svengreb approved these changes

@arcticicestudio arcticicestudio arcticicestudio approved these changes

Assignees
No one assigned
Labels
scope-quality type-improvement
Projects
None yet
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jvoisin @arcticicestudio @svengreb