Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS Code 1.14 #34

Closed
ajitid opened this issue Jul 15, 2017 · 1 comment
Closed

VS Code 1.14 #34

ajitid opened this issue Jul 15, 2017 · 1 comment
Labels
context-ui type-feature
Milestone
version-0.5.0

Comments

@ajitid
Copy link
Contributor

ajitid commented Jul 15, 2017 •
edited
Loading

VS Code 1.14 breaks heads-up notification label and button colors.

screenshot 215

New keys are here: microsoft/vscode#28280

Also 1.14 has introduced keyboard shortcuts as buttons in command palette, maybe there exist few keys for it too...

screenshot 216
@arcticicestudio arcticicestudio added this to the 0.5.0 milestone Jul 15, 2017
@arcticicestudio
Copy link
Contributor

Thanks for your report 👍
I've also tracked the PR regarding the new notification button selectors and had already created a backlog note card.

There are no selectors listed for the keyboard shortcut indicators in the theme color reference guide, maybe this will be added to the next version.

@arcticicestudio arcticicestudio self-assigned this Aug 5, 2017
arcticicestudio added a commit that referenced this issue Aug 5, 2017
@arcticicestudio
Implement notification badge- and button styles
da33e12 
VS Code 1.14 introduced two changes to the notification styles. The
buttons now using specific setting keys instead of the main "button.*"
keys and the notification level badges can be customized with specific
setting keys.

GH-34
@arcticicestudio arcticicestudio mentioned this issue Aug 5, 2017
Merged
arcticicestudio added a commit that referenced this issue Aug 7, 2017
@arcticicestudio
Merge pull request #36 from arcticicestudio/feature/gh-34-vs-code-1.14
eb649b0 
VS Code 1.14
@arcticicestudio arcticicestudio removed their assignment Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-ui type-feature
Projects
None yet
Milestone
version-0.5.0
Development

No branches or pull requests
2 participants
@arcticicestudio @ajitid