Remove meta.var.expr from scope selector #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcticicestudio
approved these changes
Mar 23, 2019
There was a problem hiding this comment.
Supersedes #97
Thanks again 👍
This is exactly what I meant, the superfluous meta.var.expr has prevented that the defined color gets applied to the variables.
The website was the most-time project the last months, I'm really happy it is now available on the production domain 😄
I'll merge this PR to include it into the next extension release version 🚀
Release Note Assets
Before
After
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the requested changes from #97
I was able to retrieve the change from the orphan pull request but unfortunately, could not link the requested change to it. It should also close #97
Let me know if this is what you had in mind. Also congrats on the website launch!