Remove prefix attribute from <html> tag

This is not necessary to support the Open Graph Protocol metadata and can lead to problems with other specifications. GH-106`
nordtheme · Dec 26, 2018 · aa1ab35 · aa1ab35
1 parent abf4318
commit aa1ab35
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 12 deletions.
diff --git a/src/components/atoms/core/SiteMetadata/SiteMetadata.jsx b/src/components/atoms/core/SiteMetadata/SiteMetadata.jsx
@@ -40,7 +40,7 @@ const PureSiteMetadata = ({
 }) => (
   <Fragment>
     <Helmet defaultTitle={title} titleTemplate={`${title} | %s`}>
-      <html lang="en" prefix="og: http://ogp.me/ns#" />
+      <html lang="en" />
       <meta content={description} name="description" />
       <meta content={author.name} name="author" />
       <meta content={Array.from(new Set([...keywordsNord, ...keywordsNordDocs]))} name="keywords" />

diff --git a/test/components/atoms/core/SiteMetadata/SiteMetadata.test.jsx b/test/components/atoms/core/SiteMetadata/SiteMetadata.test.jsx
@@ -132,17 +132,6 @@ describe("data consistency", () => {
     );
   });
 
-  test("contains Open Graph Protocol HTML schema `prefix` attribute", () => {
-    renderWithTheme(<SiteMetadata data={staticQueryResultDataMock} pathName="/" />);
-    const generatedHelmetData = Helmet.peek();
-
-    expect(generatedHelmetData.htmlAttributes).toEqual(
-      expect.objectContaining({
-        prefix: expect.stringContaining("ogp.me")
-      })
-    );
-  });
-
   test("contains JSON-LD schema linked data `script` tag", () => {
     renderWithTheme(<SiteMetadata data={staticQueryResultDataMock} pathName="/" />);
     const generatedHelmetData = Helmet.peek();