Prettier #21
Merged
Prettier #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arcticicestudio
commented
Nov 17, 2018
arcticicestudio
commented
Installed the main "prettier" (1) package and "eslint-plugin-prettier" (2) for ESLint compatibility. References: (1) https://www.npmjs.com/package/prettier (2) https://www.npmjs.com/package/eslint-plugin-prettier GH-16
This is one of the main features of Prettier: It already provides the best and recommended style configurations of-out-the-box. The only option that has been changed is the print width (1). It is set to 80 by default which not up-to-date for modern screens (might only be relevant when working in terminals only like e.g. with Vim). It is now set to 120 used by all of Arctic Ice Studio's style guides. The `prettier.config.js` configuration file is placed in the project root as well as the `.prettierignore` file that defines ignore pattern. References: (1) https://prettier.io/docs/en/options.html#print-width GH-16
To be fully compatible with ESLint (implemented in GH-15), eslint-plugin-prettier (1) has been added to the plugins array of the ESLint configuration. To enable full compatibility the `prettier/prettier` rule has been added with the `error` level. References: (1) https://www.npmjs.com/package/eslint-plugin-prettier GH-16
To allow to format all sources the `format:pretty` NPM script/task has been added to be included in the main format script flow later on. GH-16
Run Prettier on the current code base for the first time to format according to the configuration. GH-16
svengreb
approved these changes
Nov 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.