Base Media Query Setup #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arcticicestudio
commented
Dec 5, 2018
arcticicestudio
commented
To simplify the usage of media queries (1) with styled-components (2), a utility function to generate media templates (3) will be implemented. It'll use the `min-width` parameter to fulfill the used "mobile-first" approach. The base size that'll be used has been implemented as theme property in GH-54 (4). References: (1) https://developer.mozilla.org/de/docs/Web/CSS/Media_Queries/Using_media_queries (2) #52 (3) https://www.styled-components.com/docs/advanced#media-templates (4) https://github.com/arcticicestudio/nord-docs/pull/55/files#diff-90a2aa45c339ce4720a7fbbd23c65e3eR49 Associated epic: #52 GH-61
| Always adjust media queries to the content individually and not vice-versa. | The design supports the content. Not the other way around. Like documented in the GH-52, Nord Docs uses the mobile-first pattern and follows the great "Google Developer Responsive Web Design guidelines (1). The recommended way is to create media queries not based on any device sizes but individually based on the content which is unique for each project. This is the best practice and, contrary to most popular CSS framework like Bootstrap, the correct way since each site is different and there are thousands of devices and in the future new sizes will appear. Therefore, this commit includes the initial media query template functions that define the smallest `min-width` query `base` (`<320px`) and `minimal` (`>=320px`). References: (1) https://developers.google.com/web/fundamentals/design-and-ux/responsive Associated epic: GH-52 GH-61
Codecov Report
@@ Coverage Diff @@
## develop #62 +/- ##
===========================================
+ Coverage 78.57% 79.66% +1.08%
===========================================
Files 17 20 +3
Lines 56 59 +3
Branches 9 9
===========================================
+ Hits 44 47 +3
Misses 9 9
Partials 3 3
Continue to review full report at Codecov.
|
svengreb
approved these changes
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.