Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core Atom HTML Element: P #80

Merged
merged 1 commit into from
Dec 16, 2018
Merged

Core Atom HTML Element: P #80

merged 1 commit into from
Dec 16, 2018

Conversation

arcticicestudio
Copy link
Contributor

Resolves #79

@arcticicestudio
Implement core atom HTML element component "P"
f86bab6 
This commit implements the core atom `P` that represents the text
content (1) HTML element `<p>`.
It uses adjusted styles instead of browser defaults to match Nord Docs
style.

References:
  (1) https://developer.mozilla.org/en-US/docs/Web/HTML/Element#Text_content

Associated epic: GH-69
GH-79
@arcticicestudio arcticicestudio added this to the 0.3.0 milestone Dec 16, 2018
@arcticicestudio arcticicestudio self-assigned this Dec 16, 2018
@codecov
Copy link

codecov bot commented Dec 16, 2018 •
edited
Loading

Codecov Report

Merging #80 into develop will decrease coverage by 3.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #80      +/-   ##
===========================================
- Coverage    75.37%   72.36%   -3.02%     
===========================================
  Files           54       55       +1     
  Lines          199      199              
  Branches        34       34              
===========================================
- Hits           150      144       -6     
- Misses          49       52       +3     
- Partials         0        3       +3
Flag Coverage Δ
#unit 72.36% <100%> (-3.02%) ⬇️
Impacted Files Coverage Δ
...toms/core/HTMLElements/inline-text-semantics/A.jsx 100% <ø> (ø)
...ponents/atoms/core/HTMLElements/text-content/P.jsx 100% <100%> (ø)
...omponents/organisms/core/Header/styled/SunIcon.jsx 50% <0%> (-50%) ⬇️
...mponents/organisms/core/Header/styled/MoonIcon.jsx 50% <0%> (-50%) ⬇️
src/components/atoms/core/vectors/icons/Sun.jsx 80% <0%> (-20%) ⬇️
src/utils/sessionCache.js 60% <0%> (-20%) ⬇️
src/utils/isRoutePartiallyMatch.js 87.5% <0%> (-12.5%) ⬇️
src/styles/theme/utils/generateMediaQuery.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47010b8...f86bab6. Read the comment docs.

@arcticicestudio arcticicestudio merged commit ad995b0 into develop Dec 16, 2018
@arcticicestudio arcticicestudio deleted the feature/gh-79-core-atom-html-element-p branch December 16, 2018 16:53
@arcticicestudio arcticicestudio removed their assignment Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svengreb svengreb svengreb approved these changes

Assignees
No one assigned
Labels
context-api context-ui type-feature
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@arcticicestudio @svengreb