Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core Atom HTML Element: Heading #82

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Core Atom HTML Element: Heading #82

merged 1 commit into from
Dec 17, 2018

Conversation

arcticicestudio
Copy link
Contributor

Resolves #81

@arcticicestudio
Implement core atom HTML element component Heading
0d629ca 
This commit implements the core atom(s) `H1`-`H6` which represent the
content sectioning (1) HTML element `<h1>`-`<h6>` (2).

It uses custom styles instead of browser defaults and allows to disable
the bottom margin via the `noMargin` prop. The font styles like size,
modular scale and family adhere to the "Typography" design concept (3).

References:
  (1) https://developer.mozilla.org/en-US/docs/Web/HTML/Element#Content_sectioning
  (2) https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements
  (3) #2

Associated epics: GH-69, GH-2
GH-81
@arcticicestudio arcticicestudio added this to the 0.3.0 milestone Dec 17, 2018
@arcticicestudio arcticicestudio self-assigned this Dec 17, 2018
@codecov
Copy link

codecov bot commented Dec 17, 2018 •
edited
Loading

Codecov Report

Merging #82 into develop will increase coverage by 2.75%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #82      +/-   ##
===========================================
+ Coverage    72.36%   75.11%   +2.75%     
===========================================
  Files           55       56       +1     
  Lines          199      221      +22     
  Branches        34       35       +1     
===========================================
+ Hits           144      166      +22     
  Misses          52       52              
  Partials         3        3
Flag Coverage Δ
#unit 75.11% <100%> (+2.75%) ⬆️
Impacted Files Coverage Δ
src/components/atoms/core/HTMLElements/text/P.jsx 100% <ø> (ø)
...nts/atoms/core/HTMLElements/sectioning/Heading.jsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad995b0...0d629ca. Read the comment docs.

@arcticicestudio arcticicestudio merged commit c4e1aa8 into develop Dec 17, 2018
@arcticicestudio arcticicestudio deleted the feature/gh-81-core-atom-html-element-heading branch December 17, 2018 10:03
@arcticicestudio arcticicestudio removed their assignment Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svengreb svengreb svengreb approved these changes

Assignees
No one assigned
Labels
context-api context-ui type-feature
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@arcticicestudio @svengreb