Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed version of nose differ from GitHub repository and is not Python 3.10 compatible #1118

Open
fnordahl opened this issue Mar 8, 2022 · 3 comments

Comments

@fnordahl
Copy link

fnordahl commented Mar 8, 2022

The distributed version of nose looks like this:

    def _set_tests(self, tests):
        self._precache = []
        is_suite = isinstance(tests, unittest.TestSuite)
        if isinstance(tests, collections.Callable) and not is_suite:

The same code in this repository is different:

nose/nose/suite.py

Lines 102 to 105 in 7c26ad1

def _set_tests(self, tests):
self._precache = []
is_suite = isinstance(tests, unittest.TestSuite)
if callable(tests) and not is_suite:

According to git history the above has not changed in 15 years.

As a consequence the distributed version is not Python 3.10 compatible, and I don't know how to contribute a fix because it is apparently already fixed.

Is there any plans for a new version that contains the correct code?

fnordahl added a commit to openstack-charmers/zaza that referenced this issue Mar 8, 2022
The distributed version of nose is not Python 3.10 compatible,
ref: nose-devs/nose#1118.
fnordahl added a commit to openstack-charmers/zaza that referenced this issue Mar 8, 2022
The distributed version of nose is not Python 3.10 compatible,
ref: nose-devs/nose#1118.
fnordahl added a commit to openstack-charmers/zaza that referenced this issue Mar 8, 2022
The distributed version of nose is not Python 3.10 compatible,
ref: nose-devs/nose#1118.
@datalogics-robb
Copy link

@fnordahl this project hasn't been maintained for many years. The last PR merged was 6 years ago, and I think the official stance even then was this was no longer maintained.

@matkoniecz
Copy link

@datalogics-robb Can you recomment some alternatives?

freyes added a commit to freyes/juju-bundlelib that referenced this issue Apr 1, 2022
nose is broken for python>=3.10 and upstream has indicated that it's
deprecated[0]. nose2 is, in spirit, the successor.

[0] nose-devs/nose#1118 (comment)
@dirkf
Copy link

dirkf commented Sep 30, 2022

#1099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants