Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dependency Injection for NotaryRepository initialization #932

Closed
endophage opened this issue Aug 26, 2016 · 1 comment
Closed

Improve Dependency Injection for NotaryRepository initialization #932

endophage opened this issue Aug 26, 2016 · 1 comment

Comments

@endophage
Copy link
Contributor

Currently it takes a basedir and a RoundTripper, this is fine for NewNotaryRepository which should be a simplified initializer with assumptions made. However, for unusual use cases and testing, it would be helpful to be able to inject a cache and RemoteStore directly.

We think this should probably be done by exporting repositoryFromKeystores (and maybe renaming it to something like NewRepositoryFromStores), and having it take an initialized cache and RemoteStore, rather than baseDir and rt.

@endophage
Copy link
Contributor Author

Closed by #1094

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant