make cache injectable into NotaryRepository #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Lawrence <[email protected]> (github: endophage)
endophage
force-pushed
the
inject_cache
branch
from
e346651 to
c1e269a
Compare
riyazdf
approved these changes
Oct 12, 2016
|
also as a breadcrumb, this partially addresses #932 |
cyli
approved these changes
Oct 12, 2016
| retriever notary.PassRetriever, trustPinning trustpinning.TrustPinConfig) ( | ||
| *NotaryRepository, error) { | ||
|
|
||
| func getKeyStores(baseDir string, retriever notary.PassRetriever) ([]trustmanager.KeyStore, error) { |
There was a problem hiding this comment.
Non-blocking: It might be nice to make these exportable; the CLI has a function that basically replicates this for listing keys, etc, and it would be awesome to replace it with these. Can be done in a separate PR though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasonably minimal changes to make cache injectable while not having to move around much code. Also want to keep and add to "helper" constructors (e.g.
NewFileCachedNotaryRepository) rather than push too much of that code up the call stack.Also moved a bunch of errors that were in client/client.go into a new client/errors.go to keep things a little cleaner. client/client.go was a bit messy with a bunch of error types. They're still in the same scope (i.e. in the
clientpackage) so nothing else had to be changed by moving them.Signed-off-by: David Lawrence [email protected] (github: endophage)