Pass the netgo tag when building static binaries #1038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riyazdf
approved these changes
Nov 16, 2016
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| ## [v0.5.1](https://github.com/docker/notary/releases/tag/v0.5.1) 11/14/2016 | |||
| + If no `records` parameter is provided in a request for the changefeed, a default value of 100 is used. | |||
| + Fix build tags for static notary client binaries in linux | |||
There was a problem hiding this comment.
non-blocking nit: can we add this PR number to the changelog? I think we forgot to do it for the previous entry as well
- When building static binaries with CGO, cgo unix network segfaults - When building dynamically linked binaries with CGO, everything is fine - When building static binaries with CGO but with -tags netgo passed, everything is fine So update our cross and static builds to include netgo. prometheus/alertmanager#304 golang/go#7857 Signed-off-by: Ying Li <[email protected]>
cyli
force-pushed
the
fix-cross-builds
branch
from
8259514 to
05dbc1c
Compare
|
Have filed golang/go#17935 to see if it's an issue in go |
|
Superseded by #1072 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So add the netgo tag when building static binaries.
prometheus/alertmanager#304
golang/go#7857