Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove please and change our to Notary's in README #1256

Merged
merged 1 commit into from
Nov 2, 2017
Merged

remove please and change our to Notary's in README #1256

merged 1 commit into from
Nov 2, 2017

Conversation

eiais
Copy link
Contributor

@eiais eiais commented Oct 31, 2017

Signed-off-by: Kyle Spiers [email protected]

Copy link
Contributor

@riyazdf riyazdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -110,11 +110,11 @@ Notary is checked out to the `src` directory in your `GOPATH`. For example:
$GOPATH/
src/
github.com/
docker/
theupdateframework/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch here!

@riyazdf
Copy link
Contributor

riyazdf commented Nov 1, 2017

for context, much of these fixes come from docs review in: docker/cli#472

Copy link
Contributor

@HuKeping HuKeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Thanks @eiais

@riyazdf riyazdf merged commit 86888f1 into notaryproject:master Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants