Fix role parsing in golang 1.17+ #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylewuolle
force-pushed
the
fix-role-parsing
branch
from
2f61105 to
8ad91a3
Compare
|
Ping @thaJeztah @marcofranssen |
thaJeztah
approved these changes
Apr 30, 2022
|
ping @justincormack @HuKeping PTAL (also looks like CI is no longer running, including |
…ader to support later versions of golang which will remove anything prior to a slash in the filename field. Signed-off-by: Kyle Wuolle <[email protected]>
kylewuolle
force-pushed
the
fix-role-parsing
branch
from
a271a86 to
efc35b0
Compare
jonnystoten
approved these changes
May 30, 2022
justincormack
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In golang 1.17 a change was made to remove anything preceding a slash from the filename field of the Content-Disposition header. This causes a problem with notary since it's using the filename field for the role value. This fix changes the parsing of the header value so it grabs the raw filename value instead of using the method that removes the base part of the filename.
This is also outlined in this issue:
#1630