Remove the HTTP endpoint for Notary Signer #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyli
force-pushed
the
remove-signer-http-interface
branch
from
e2bf987 to
a487935
Compare
|
👍 Thanks for the ping. It's great to see this |
…ing. This removes the maintenance burden of keeping them in sync. Signed-off-by: Ying Li <[email protected]>
cyli
force-pushed
the
remove-signer-http-interface
branch
from
a487935 to
5d6bd65
Compare
| localhost only. That means that the server will not be | ||
| accessible except locally (via SSH tunnel, or just on a local | ||
| terminal)</li> | ||
| </ul> |
There was a problem hiding this comment.
thank you for updating docs too! 👍
|
this is awesome, LGTM |
|
All the LGTMs! |
|
@endophage is this for v0.4.0? |
|
@SvenDowideit given it has been merged, yes it will be included in 0.4.0. Note it's only the signer that is losing plain HTTP endpoints, and nobody but the server was talking to the signer (and the server was only using GRPC). |
|
cool - the docs tooling uses the milestone to determine if a PR should be published, so I've added 0.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since its' not used by anything. The signer is generally kept hidden in notary service deployments anyway, and the GRPC interface is the main supported interface.
cc @NathanMcCauley
I also wanted to check if anyone was doing anything with the HTTP interface first, though. @andrewhsu @ecordell @HuKeping @mtrmac?