Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add a blog for Notation v1.2.0 release #408

Merged
merged 15 commits into from
Sep 4, 2024
Merged

doc: add a blog for Notation v1.2.0 release #408

merged 15 commits into from
Sep 4, 2024

Conversation

yizha1
Copy link
Contributor

@yizha1 yizha1 commented Aug 29, 2024

Updates:

  • Create a blog for Notation v1.2.0 release

Signed-off-by: Yi Zha [email protected]

@netlify Netlify
Copy link

netlify bot commented Aug 29, 2024 •
edited
Loading

✅ Deploy Preview for notarydev ready!

Name Link
🔨 Latest commit 4c17589
🔍 Latest deploy log https://app.netlify.com/sites/notarydev/deploys/66d7137be732700008c601ee
😎 Deploy Preview https://deploy-preview-408--notarydev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

FeynmanZhou
FeynmanZhou reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yizha1 . Overall looks good to me. Just a few small suggested changes.

content/en/blog/2024/announcing-notation-v1-2.md Outdated Show resolved Hide resolved
content/en/blog/2024/announcing-notation-v1-2.md Outdated Show resolved Hide resolved
content/en/blog/2024/announcing-notation-v1-2.md Outdated Show resolved Hide resolved
content/en/blog/2024/announcing-notation-v1-2.md Outdated Show resolved Hide resolved
@yizha1
update per comments
0fb19dc 
Signed-off-by: Yi Zha <[email protected]>
@yizha1
update
668d0f3 
Signed-off-by: Yi Zha <[email protected]>
@yizha1 yizha1 requested a review from Two-Hearts August 29, 2024 08:11
Two-Hearts
Two-Hearts approved these changes Aug 29, 2024
View reviewed changes
Copy link

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FeynmanZhou
FeynmanZhou reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny markdown format issue

content/en/blog/2024/announcing-notation-v1-2.md Outdated Show resolved Hide resolved
@yizha1
update per comments
12871d8 
Signed-off-by: Yi Zha <[email protected]>
@yizha1 yizha1 requested a review from FeynmanZhou August 29, 2024 08:23
FeynmanZhou
FeynmanZhou previously approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This PR can be merged after its referenced doc PR #407 is merged.

@yizha1 yizha1 changed the base branch from v1-2 to main August 29, 2024 09:23
@yizha1 yizha1 dismissed FeynmanZhou’s stale review August 29, 2024 09:23

The base branch was changed.

FeynmanZhou
FeynmanZhou previously approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao approved these changes Aug 30, 2024
View reviewed changes
Copy link

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but IANAM

@yizha1 yizha1 requested a review from shizhMSFT August 30, 2024 09:03
@yizha1 yizha1 dismissed stale reviews from shizhMSFT and FeynmanZhou via ddb23fd August 30, 2024 09:51
FeynmanZhou
FeynmanZhou previously approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT previously approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vaninrao10
vaninrao10 previously approved these changes Sep 3, 2024
View reviewed changes
Copy link

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yizha1 yizha1 dismissed stale reviews from vaninrao10, FeynmanZhou, and shizhMSFT via 6cfa64e September 3, 2024 03:51
@yizha1
fix links
240831e 
Signed-off-by: Yi Zha <[email protected]>
@yizha1
fix links
6f44d78 
Signed-off-by: Yi Zha <[email protected]>
@yizha1
remove ref
8421ece 
Signed-off-by: Yi Zha <[email protected]>
@yizha1
remove ref
3c1ca6d 
Signed-off-by: Yi Zha <[email protected]>
FeynmanZhou
FeynmanZhou previously approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

whalelines
whalelines reviewed Sep 3, 2024
View reviewed changes
Copy link

@whalelines whalelines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A couple comments…

content/en/blog/2024/announcing-notation-v1-2.md Show resolved Hide resolved
content/en/blog/2024/announcing-notation-v1-2.md Show resolved Hide resolved
content/en/blog/2024/announcing-notation-v1-2.md Outdated Show resolved Hide resolved
FeynmanZhou
FeynmanZhou approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeynmanZhou FeynmanZhou merged commit f167fb0 into notaryproject:main Sep 4, 2024
5 checks passed
@yizha1 yizha1 deleted the doc-1.2blog branch September 5, 2024 00:14
@yizha1 yizha1 mentioned this pull request Sep 5, 2024
Merged
yizha1 added a commit that referenced this pull request Sep 11, 2024
@yizha1
chore: fix the inaccurate information in the v1.2 blog (#415)
da7fcb2 
Update:
- Fix according to the comment
#408 (comment)

Signed-off-by: Yi Zha <[email protected]>

---------

Signed-off-by: Yi Zha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whalelines whalelines whalelines left review comments

@Two-Hearts Two-Hearts Two-Hearts approved these changes

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@FeynmanZhou FeynmanZhou FeynmanZhou approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@shizhMSFT shizhMSFT shizhMSFT left review comments

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@iamsamirzon iamsamirzon Awaiting requested review from iamsamirzon iamsamirzon is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@yizha1 @priteshbandi @shizhMSFT @FeynmanZhou @JeyJeyGao @vaninrao10 @Two-Hearts @whalelines