Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check-line-endings command of Makefile #252

Merged
merged 2 commits into from
Dec 30, 2024
Merged

fix: check-line-endings command of Makefile #252

merged 2 commits into from
Dec 30, 2024

Conversation

JeyJeyGao
Copy link
Contributor

Fix:

  • update the command to search script file in . instead of scripts/ folder to avoid returning an error.

@JeyJeyGao JeyJeyGao marked this pull request as ready for review December 26, 2024 06:26
@codecov Codecov
Copy link

codecov bot commented Dec 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (2cd55de) to head (8b72b25).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #252   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files          31       31           
  Lines        2645     2645           
=======================================
  Hits         2434     2434           
  Misses        161      161           
  Partials       50       50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeyJeyGao JeyJeyGao changed the title fix: check-line-endings commands of Makefile fix: check-line-endings command of Makefile Dec 26, 2024
Two-Hearts
Two-Hearts approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 030abc2 into notaryproject:main Dec 30, 2024
9 checks passed
@JeyJeyGao JeyJeyGao deleted the fix/Makefile branch December 30, 2024 02:13
@Two-Hearts Two-Hearts mentioned this pull request Jan 14, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priteshbandi priteshbandi priteshbandi approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@Two-Hearts Two-Hearts Two-Hearts approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JeyJeyGao @priteshbandi @shizhMSFT @Two-Hearts