-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error logs for notation sign #868
Comments
JeyJeyGao
added a commit
to Azure/notation-azure-kv
that referenced
this issue
Jan 29, 2024
Improve the error message: Previous: ``` notation sign notationreg.azurecr.io/hello-app:v2 --plugin azure-kv --id https://acrci-test-kv.vault.azure.net/keys/self-signed-pkcs13/70747b2064c0488e936eba7a29acc4c6 Warning: Always sign the artifact using digest(@sha256:...) rather than a tag(:v2) because tags are mutable and a tag reference can point to a different artifact than the one signed. Error: describe-key command failed: failed to execute the describe-key command for plugin azure-kv: ERROR: A certificate with (name/id) self-signed-pkcs13/versions/70747b2064c0488e936eba7a29acc4c6 was not found in this key vault. If you recently deleted this certificate you may be able to recover it using the correct recovery command. For help resolving this issue, please see https://go.microsoft.com/fwlink/?linkid=2125182 Status: 404 (Not Found) ErrorCode: CertificateNotFound Content: {"error":{"code":"CertificateNotFound","message":"A certificate with (name/id) self-signed-pkcs13/versions/70747b2064c0488e936eba7a29acc4c6 was not found in this key vault. If you recently deleted this certificate you may be able to recover it using the correct recovery command. For help resolving this issue, please see https://go.microsoft.com/fwlink/?linkid=2125182"}} Headers: Cache-Control: no-cache Pragma: no-cache x-ms-keyvault-region: eastus x-ms-client-request-id: 94abafcf-db8e-4046-be8a-573360b627eb x-ms-request-id: b6c9de19-768c-4187-90d3-17342827af20 x-ms-keyvault-service-version: 1.9.1222.3 x-ms-keyvault-network-info: conn_type=Ipv4;addr=167.220.255.20;act_addr_fam=InterNetwork; X-Content-Type-Options: REDACTED Strict-Transport-Security: REDACTED Date: Mon, 29 Jan 2024 06:52:00 GMT Content-Length: 372 Content-Type: application/json; charset=utf-8 Expires: -1 ``` Current: ``` notation sign notationreg.azurecr.io/hello-app:v2 --plugin azure-kv --id https://acrci-test-kv.vault.azure.net/keys/self-signed-pkcs13/70747b2064c0488e936eba7a29acc4c6 Warning: Always sign the artifact using digest(@sha256:...) rather than a tag(:v2) because tags are mutable and a tag reference can point to a different artifact than the one signed. Error: describe-key command failed: failed to execute the describe-key command for plugin azure-kv: CertificateNotFound: A certificate with (name/id) self-signed-pkcs13/versions/70747b2064c0488e936eba7a29acc4c6 was not found in this key vault. If you recently deleted this certificate you may be able to recover it using the correct recovery command. For help resolving this issue, please see https://go.microsoft.com/fwlink/?linkid=2125182 ``` Resolves part of notaryproject/notation#868 Signed-off-by: Junjie Gao <[email protected]> Signed-off-by: Junjie Gao <[email protected]>
|
github-project-automation
bot
moved this from Todo
to Done
in Notary Project Planning Board
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is not working as expected?
This issue summarizes the error messages of
notation sign
that I suggest improving in v1.1.x.Sign an artifact with an non-existing signing key in a key vault
Current behavior and output:
Suggested error message:
Sign an artifact with an error signature format parameter
Current behavior and output:
Suggested error message:
What did you expect to happen?
See above
How can we reproduce it?
See above
Describe your environment
Linux Ubuntu 22.06
What is the version of your Notation CLI or Notation Library?
v1.0.1
The text was updated successfully, but these errors were encountered: