Add scenario for user-specified key #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marina Moore <[email protected]>
|
LGTM |
|
@SteveLasker or @justincormack I don't have permission to merge in this repo, could you add this and #47? |
|
Lgtm as well! |
SteveLasker
approved these changes
Jun 7, 2021
|
|
||
| **Implications of this requirement** | ||
|
|
||
| 1. Users must be allowed to configure specific trusted keys for specific artifacts or collections of artifacts. |
There was a problem hiding this comment.
The wording around collections of artifacts might be inferred to something around a repository collection. As artifacts move within and across registries, a repository may have multiple signing keys.
I'll LGTM and we can clarify later if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves scenario 10 from #66 into it's own pr with a couple of minor clarifications.