-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cms #17
feat: add cms #17
Conversation
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as all of my review comments in notaryproject/notation-core-go#181 are resolved.
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
commit 2862807 Author: Junjie Gao <[email protected]> Date: Wed Jan 31 15:21:55 2024 +0800 feat: ber to der convertor (notaryproject#11) Signed-off-by: Junjie Gao <[email protected]> commit a373599 Author: Patrick Zheng <[email protected]> Date: Mon Jan 22 16:37:33 2024 +0800 ci: add MAKEFILE and build workflow to the repo (notaryproject#19) Signed-off-by: Patrick Zheng <[email protected]> commit 6fa8c7f Author: Patrick Zheng <[email protected]> Date: Mon Jan 22 16:36:50 2024 +0800 ci: add dependabot (notaryproject#16) Signed-off-by: Patrick Zheng <[email protected]> commit bdae447 Author: Patrick Zheng <[email protected]> Date: Mon Jan 22 16:36:24 2024 +0800 ci: add code coverage check (notaryproject#15) Signed-off-by: Patrick Zheng <[email protected]> commit 4cc6846 Author: Patrick Zheng <[email protected]> Date: Mon Jan 22 16:35:54 2024 +0800 ci: add license checker to the repo (notaryproject#13) Signed-off-by: Patrick Zheng <[email protected]> commit a27c098 Author: Yi Zha <[email protected]> Date: Thu Jan 18 10:02:22 2024 +0800 chore: add CODEOWNERS and MAINTAINERS file (notaryproject#12) Resolve notaryproject#2 Signed-off-by: Yi Zha <[email protected]> Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Signed-off-by: Junjie Gao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Junjie Gao <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
=======================================
Coverage ? 95.18%
=======================================
Files ? 10
Lines ? 353
Branches ? 0
=======================================
Hits ? 336
Misses ? 9
Partials ? 8 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Junjie Gao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Junjie Gao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Junjie Gao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Junjie Gao [email protected]