Add git rm options

[MoOx]

I just duplicate add options to remove to be able to do "git rm -r ."

[notatestuser]

Are you sure we couldn't improve the readability of the logic on L368? Bear in mind that the callback is undefined.

[MoOx]

@notatestuser I just grab the lines for add() method

gift/src/repo.coffee

Lines 354 to 358 in e1e6973

	add: (files, options, callback) ->
	[options, callback] = [callback, options] if !callback
	options ?= {}
	files = [files] if _.isString files
	@git "add", options, files, callback

[notatestuser]

Okay, that could use a bit of spring cleaning too.

[MoOx]

So do you want me to clean this thing ?
That said, I'm not really comfortable with cs.

[notatestuser]

No worries, leave that to me. Thanks for the PR.

-----Original Message-----
From: "Maxime Thirouin" [email protected]
Sent: ‎20/‎04/‎2014 05:15
To: "notatestuser/gift" [email protected]
Cc: "Luke Plaster" [email protected]
Subject: Re: [gift] Add git rm options (#24)

So do you want me to clean this thing ?
That said, I'm not really comfortable with cs.
—
Reply to this email directly or view it on GitHub.

[michealbenedict]

Any update on when this PR would get merged in?

[notatestuser]

Pushed to npm in 0.4.1

[michealbenedict]

perfect, thanks!

[kmctown]

I had to use { "r": true, "f": true } to get this to work -- is that expected? It didn't match the documentation.

[MoOx]

It's working for in the gulp-gh-pages task. Not sure why you need --force here.

[kmctown]

It works without the force -- I am using that because I am blowing away staged changes. Should've been more clear. I was trying to follow the "recursive" comment documentation at https://github.com/notatestuser/gift/blob/master/src/repo.coffee?#L364 before passing in the r and f switches. I'm new to the library so maybe that's common elsewhere and I just haven't run into it yet.