Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repo.checkoutFile and repo.reset #31

Merged
merged 20 commits into from
Jul 14, 2014
Merged

Add repo.checkoutFile and repo.reset #31

merged 20 commits into from
Jul 14, 2014

Conversation

nshtg
Copy link

@nshtg nshtg commented Jun 19, 2014

Was missing those, so I added them. Getting into the mocha beforeEach and before was confusing but I think I made it work.

@nshtg
Copy link
Author

nshtg commented Jun 20, 2014

I figured it out - I need to run git init on the copied repository to make it work.

Please don't wonder about your inbox by travis, I was a bad boy and reset --hard all the faulty trys I uploaded here, they would just pollute the history. 😉

@notatestuser
Copy link
Owner

Must we disable node 0.8 on travis to accept these changes?

@nshtg
Copy link
Author

nshtg commented Jun 20, 2014

Some dependencies fail to install on 0.8.

npm ERR! Error: No compatible version found: rimraf@'^2.2.8'

npm ERR! Valid install targets:

npm ERR! ["1.0.0","1.0.1","1.0.2","1.0.4","1.0.5","1.0.6","1.0.7","1.0.8","1.0.9","2.0.0","2.0.1","2.0.2","2.0.3","2.1.0","2.1.1","2.1.2","2.1.3","2.1.4","2.2.0","2.2.1","2.2.2","2.2.3","2.2.4","2.2.5","2.2.6","2.2.8"]

And later on

npm ERR! Error: No compatible version found: ncp@'^0.5.1'

npm ERR! Valid install targets:

npm ERR! ["0.0.0","0.0.1","0.0.2","0.1.0","0.1.1","0.1.2","0.2.0","0.2.1","0.2.2","0.2.3","0.2.4","0.2.5","0.2.6","0.3.0","0.4.0","0.2.7","0.4.1","0.4.2","0.5.0","0.5.1"]

We can probably replace rimraf completely with fs-extra, I'll check if that fixes the 0.8 error when I'm back home.

@notatestuser
Copy link
Owner

Cool, much appreciated.

@nshtg
Copy link
Author

nshtg commented Jun 20, 2014

Okay seems like fs-extra dropped 0.8 support 2 months ago. When I'm back home I'll see if we can replace it with wrench or fs-plus.

@nshtg
Copy link
Author

nshtg commented Jun 20, 2014

@notatestuser
The problem is caused by the old npm version node 0.8 bundles. I 'fixed' those errors by forcing travis to update npm to a newer version for each test.

Replaced rimraf with fs-extra as proposed.

@nshtg
Copy link
Author

nshtg commented Jun 24, 2014

Anything left you want me to change?

notatestuser added a commit that referenced this pull request Jul 14, 2014
Add repo.checkoutFile and repo.reset
@notatestuser notatestuser merged commit 5836f32 into notatestuser:master Jul 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants