Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when getting the current branch but it is checked out to a commit #33

Merged
merged 2 commits into from
Aug 21, 2014

Conversation

shaoshing
Copy link

  1. when a repo checkout to a existing branch, its HEAD file would be "ref: refs/heads/{branch name}"
  2. when it is checkout to a commit, its HEAD file would be the commit hash, e.g. "d85f686d388e333abde2ac89020f2f127d9d7e9d"

This pull request handle the second scenario by returning an error indicating that the current branch is not a valid branch.

@notatestuser
Copy link
Owner

Thanks. I'll take a look soon.

@jspiro
Copy link

jspiro commented Jul 15, 2014

+1

notatestuser added a commit that referenced this pull request Aug 21, 2014
Fix error when getting the current branch but it is checked out to a commit
@notatestuser notatestuser merged commit 03a024e into notatestuser:master Aug 21, 2014
@notatestuser
Copy link
Owner

Thanks again.

@jspiro
Copy link

jspiro commented Aug 29, 2014

@notatestuser Could you push a new version to npm? This has been a blocker for me for a few weeks :-)

@notatestuser
Copy link
Owner

@jspiro Published in v0.4.3.

@jspiro
Copy link

jspiro commented Aug 30, 2014

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants