Merging our works #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tests: use a working 'remotes' fixture. Old one was broken. - Tests: use chai instead of should: same API, but work properly on Date: tj/should.js#56 - Tests: use rimraf instead of executing "rm -rf": allow to work on windows - Tests: configure mocha to execute coffee-script with --compilers option
Repo.add: allow option usage to specify --all
…inary files content from history.
Includes: - Repo.commit: send stdout/stderr to callback lile other methods - Repo.commit: possibility to specify author - git.refs: ignore error code 1 which means that no refs are available. - git: use binary encoding for child_process.exec() to allow binary files content retrieval from history.
|
This looks great, thanks. It does look like Travis is having a bit of trouble with one of the tests, though. It looks like we'll need to set a commit identity in the setup for that spec. Could you take care of that? You can use this to set a commit identity: https://github.com/notatestuser/gift#repoidentifyactor-callback |
|
Done ! |
|
Good stuff. I'll get this merged ASAP. Thanks again. |
|
Published to npm as 0.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello M. Plaster.
I've been using gift since more than two years now, and made some fix and enhancement into my fork.
Unfortunately, Sentientwaffle has never answered to my pullrequest, and I'd like to use NPM version instead of my github repo.
You'll find here a merge of our both work, I hope it can be published one day :)