Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #302 to v4 #303

Merged
merged 1 commit into from
May 8, 2021
Merged

Backport #302 to v4 #303

merged 1 commit into from
May 8, 2021

Conversation

0xpr03
Copy link
Member

@0xpr03 0xpr03 commented May 4, 2021 •
edited
Loading

(cherry picked from commit 86421e5)

@0xpr03 0xpr03 force-pushed the backport_302 branch 5 times, most recently from e535f2f to bf6ec64 Compare May 6, 2021 22:34
@0xpr03
Copy link
Member Author

0xpr03 commented May 6, 2021

@JohnTitor any ideas why windows CI setup fails currently ? same on main branch

@JohnTitor
Copy link
Member

any ideas why windows CI setup fails currently ? same on main branch

Posted #304 and #305 to fix that issue. So, rustup now tries to self-update but it overrides the rustup binary, then causes a permission failure.

@0xpr03
Backport #302 to v4
9c0b83b 
(based on commit 86421e5)
Signed-off-by: Aron Heinecke <[email protected]>
@0xpr03 0xpr03 merged commit 3c8d159 into try-v4 May 8, 2021
@0xpr03 0xpr03 mentioned this pull request May 13, 2021
Merged
@0xpr03 0xpr03 deleted the backport_302 branch May 13, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xpr03 @JohnTitor