Only check for ENOSPC on inotify_add_watch #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the inotify documentation, the only function that returns ENOSPC is `inotify_add_watch`, so this moves the check for this error code to the `inotify.add_watch()` call point. This makes sure someone using a different watcher like PollWatcher on linux won't reinterpret this error. Also, this uses `libc::ENOSPC` instead of `28` because it's easier to interpret from the inotify documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the inotify documentation, the only function that returns
ENOSPCisinotify_add_watch, so this moves the check for this error code to theinotify.add_watch()call point. This makes sure someone using a different watcher like PollWatcher on linux won't reinterpret this error.Also, this uses
libc::ENOSPCinstead of28because it's easier to interpret from the inotify documentation.