Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on FreeBSD #399

Merged
merged 2 commits into from
Apr 16, 2022
Merged

Fix build on FreeBSD #399

merged 2 commits into from
Apr 16, 2022

Conversation

valpackett
Copy link
Contributor

Was failing due to non-exhaustive match which occurs because the kqueue crate has extra platform-specific enum variants.

While here, I noticed that the other BSDs had mod kqueue enabled but not the pub use re-export nor the RecommendedWatcher. Fixed that too.

The kqueue crate supports platform-specific events, so the build was failing on FreeBSD with:
error[E0004]: non-exhaustive patterns: `Open`, `CloseWrite` and `Close` not covered
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍

@0xpr03
Copy link
Member

0xpr03 commented Apr 16, 2022

This may fix #396 thanks

@0xpr03 0xpr03 merged commit 8399e41 into notify-rs:main Apr 16, 2022
@valpackett valpackett deleted the fixfbsd branch April 17, 2022 15:21
jhscheer added a commit to jhscheer/coreutils that referenced this pull request Apr 22, 2022
notify-crate:
Switch from latest release to latest commit on main branch
in order to fix the builds on FreeBSD/macOS.
notify-rs/notify#399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants