Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The fix for this PR PR https://github.com/notofonts/myanmar/issues/19 #63

Closed
wants to merge 2 commits into from

Conversation

SZTSIIT
Copy link

@SZTSIIT SZTSIIT commented Apr 22, 2023

Fixing this PR #19

Shan Glyphs errors in Noto Sans Myanmar

I am requesting this pull request is to fix this PR be fixed. It has been left alone for one or two years, and I decided to dive into the font creation, which was an amazing experience. Please accept my pull request to display Shan correctly in any application that uses the Noto Sans Myanmar font. I will explain in details what I did below.

The glyphs that I had to reshape are:

  1. ha_shn

image

  1. fa_shn

image

  1. pha_shn

image

  1. ca_khm

image

  1. ca_khm_dot

image

  1. pha_shn.sub

image

  1. pha_shn.sub2

image

  1. fa_shn.sub

image

  1. fa_shn.sub2

image

  1. ha_shn.sub

image

In Noto San Serif Myanmar
a) Eu_skn
image

Fix the combination issue by adding the ligature feature.

  1. ha_shn with _u

image

  1. ha_shn with _uu

image

  1. ha_shn with medial_wa

image

  1. ha_shn with medial_wa_shn

image

  1. ha_shn with medial_wa and asat

image

  1. ha_shn with _u and _i

image

  1. ha_shn with _uu and _i

image

  1. fa_shn with _u

image

  1. fa_shn with _uu

image

  1. fa_shn with _u and _i

image

  1. fa_shn with _uu and _i

image

  1. fa_shn with medial_wa

image

  1. fa_shn with medial_wa_shn

image

  1. fa_shn with medial_wa_shn and asat

image

Resized Shan Digits and moved up to make it level with consonants when type.
image

These two and two others “shn_ha with _u and _uu “ are already exist in NotoSans serif Myanmar. But these two are needed to repositioned medial_wa and meial_wa_shn with shn_ha
image

image

@google-cla
Copy link

google-cla bot commented Apr 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@SZTSIIT SZTSIIT closed this Apr 23, 2023
@SZTSIIT SZTSIIT reopened this Apr 23, 2023
@SZTSIIT
Copy link
Author

SZTSIIT commented Apr 23, 2023

I have to close it because the source glyph file is not the final version that generated the font here [https://fonts.google.com/noto/specimen/Noto+Sans+Myanmar]. This version has multiple error for Burmese language.

@SZTSIIT SZTSIIT closed this Apr 23, 2023
@YusukeShirakihara
Copy link

@SZTSIIT Hello. We recieved a request from a Shan native stating the wish to adjust the design for ha_shn.
In this #63 (comment), we see the ha_shn updated as desired.
We will be looking forward for the next Pull Request.

@SZTSIIT
Copy link
Author

SZTSIIT commented May 17, 2023

@YusukeShirakihara I am a Shan and Burmese native speaker. I fixed all glyphs of PR 19 as shown in this PR. I closed it because my glyph file doesn't render properly may be my glyphs app is a demo only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants