Merge pull request #81 from nov/amatsuda-warnings

⚠️ method redefined; discarding old header, signature_base_str…
nov · Jun 27, 2019 · 0531d39 · 0531d39
2 parents 03c73a5 + b258297
commit 0531d39
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/lib/json/jose.rb b/lib/json/jose.rb
@@ -9,7 +9,7 @@ module JOSE
       register_header_keys :alg, :jku, :jwk, :x5u, :x5t, :x5c, :kid, :typ, :cty, :crit
       alias_method :algorithm, :alg
 
-      attr_accessor :header
+      attr_writer :header
       def header
         @header ||= {}
       end

diff --git a/lib/json/jwe.rb b/lib/json/jwe.rb
@@ -14,9 +14,10 @@ class UnexpectedAlgorithm < JWT::UnexpectedAlgorithm; end
 
     attr_accessor(
       :public_key_or_secret, :private_key_or_secret,
-      :plain_text, :cipher_text, :authentication_tag, :iv, :auth_data,
-      :content_encryption_key, :jwe_encrypted_key, :encryption_key, :mac_key
+      :plain_text, :cipher_text, :iv, :auth_data,
+      :content_encryption_key, :encryption_key, :mac_key
     )
+    attr_writer :jwe_encrypted_key, :authentication_tag
 
     register_header_keys :enc, :epk, :zip, :apu, :apv
     alias_method :encryption_method, :enc

diff --git a/lib/json/jws.rb b/lib/json/jws.rb
@@ -6,7 +6,7 @@ class UnexpectedAlgorithm < JWT::UnexpectedAlgorithm; end
 
     NUM_OF_SEGMENTS = 3
 
-    attr_accessor :signature_base_string
+    attr_writer :signature_base_string
 
     def initialize(jwt)
       update jwt