Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Big Refactor #583

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

The Big Refactor #583

wants to merge 13 commits into from

Conversation

FiniteReality
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Yeets everything into the void only to bring it back again

Is there an open issue that this resolves? If so, please link it here.
(begins to list all open issues)

What is the current behavior? (You can also link to an open issue here)
NovelRT is a pain to build

What is the new behavior (if this is a feature change)?
NovelRT is less of a pain to build

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Almost certainly

Other information:
Hi mum, I'm on TV!

@FiniteReality FiniteReality added feature A feature ticket for the NovelRT. engine core Tickets pertaining to the engine core codebase. engine api Tickets pertaining to NovelRT's end-user API. windows Tickets specifically related to the Windows OS. linux: ubuntu Tickets specifically related to the officially supported Linux distro OS, Ubuntu. cmake Tickets specifically relating to the cmake build system. mac Tickets specifically related to MacOS. CI/CD This ticket is related to the CI/CD build pipelines. labels Jun 29, 2023
@FiniteReality FiniteReality self-assigned this Jun 29, 2023
@RubyNova RubyNova mentioned this pull request Jul 1, 2023
Merged
3 tasks
@FiniteReality
Copy link
Contributor Author

Related: #588

@FiniteReality FiniteReality mentioned this pull request Jul 2, 2023
Draft
3 tasks
@FiniteReality FiniteReality mentioned this pull request Jul 2, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannergooding tannergooding Awaiting requested review from tannergooding tannergooding will be requested when the pull request is marked ready for review tannergooding is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@FiniteReality FiniteReality

Labels
CI/CD This ticket is related to the CI/CD build pipelines. cmake Tickets specifically relating to the cmake build system. engine api Tickets pertaining to NovelRT's end-user API. engine core Tickets pertaining to the engine core codebase. feature A feature ticket for the NovelRT. linux: ubuntu Tickets specifically related to the officially supported Linux distro OS, Ubuntu. mac Tickets specifically related to MacOS. windows Tickets specifically related to the Windows OS.
Projects
None yet
Milestone
Project Sam - MVP (v1.0.0)
Development

Successfully merging this pull request may close these issues.
1 participant
@FiniteReality