Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] url prompt opener does not handle missing opener command #7002

Closed
2 tasks done
wraithgar opened this issue Nov 20, 2023 · 0 comments · Fixed by #7005 or GulajavaMinistudio/cli#82
Closed
2 tasks done

[BUG] url prompt opener does not handle missing opener command #7002

wraithgar opened this issue Nov 20, 2023 · 0 comments · Fixed by #7005 or GulajavaMinistudio/cli#82
Assignees
Labels
Bug thing that needs fixing Priority 1 high priority issue Release 10.x

Comments

@wraithgar
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

This issue exists in the latest npm version

  • I am using the latest npm

Current Behavior

In an environment (such as GitHub codespaces) that does not have a working opener (in this case, xdg-open) the error is not caught gracefully by npm when trying to open the url.

This is similiar to the bug that was just fixed in npm repo for the same case. There are two times npm opens urls, and only the non-prompting one was fixed.

Expected Behavior

npm may not be able to show a different message here, but it can catch the error and tell the user to manually go to the url.

Steps To Reproduce

  1. Load up codespaces
  2. Run npm login
  3. Hit enter to have npm try to open the web auth url
  4. See error...

Environment

  • npm: 10.2.4
  • Node.js: 20.9.0
  • OS Name: codespaces (linux)
  • npm config is not relevant here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Priority 1 high priority issue Release 10.x
Projects
None yet
1 participant