ignore the sort in help-search more broadly #2574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlf
approved these changes
Jan 29, 2021
darcyclarke
added
Release 7.x
It turns out that the other stuff in those objects might also be in random order, so this is still triggering CI coverage failures, albeit more rarely than it used to. Just ignore the whole sort function. It's fine, we implicitly assert on the sortedness in the test, so we know that it is doing its job. PR-URL: #2574 Credit: @isaacs Close: #2574 Reviewed-by: @nlf
isaacs
force-pushed
the
isaacs/broader-istanbul-ignore-in-help-search
branch
from
e19a8df to
7898f23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the other stuff in those objects might also be in
random order, so this is still triggering CI coverage failures, albeit
more rarely than it used to.
Just ignore the whole sort function. It's fine, we implicitly assert on
the sortedness in the test, so we know that it is doing its job.
References