Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config tweaks #7574

Merged
merged 4 commits into from
May 30, 2024
Merged

config tweaks #7574

merged 4 commits into from
May 30, 2024

Conversation

wraithgar
Copy link
Member

Moves over to using @npmcli/package-json

Also does not try parsing workspaces if there are none

  • deps: remove read-package-json-fast
  • deps: @npmcli/[email protected]
  • fix: use @npmcli/package-json to parse local package
  • fix: don't try parsing workspaces if none exist

@wraithgar wraithgar requested a review from a team as a code owner May 30, 2024 14:52
@npm-cli-bot
Copy link
Collaborator

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only modules-only no-lock no-cache no-modules no-clean show-version run-script cache-only
peer-deps
no-clean
audit
npm@latest 38.573 ±0.36 11.016 ±0.03 12.002 ±0.11 1.560 ±0.04 1.601 ±0.01 1.267 ±0.00 8.311 ±0.09 1.304 ±0.02 0.144 ±0.00 0.164 ±0.00 15.093 ±0.27 2.264 ±0.11
#7574 38.499 ±2.85 10.930 ±0.07 12.048 ±0.09 1.617 ±0.01 1.565 ±0.01 1.291 ±0.00 8.349 ±0.05 1.311 ±0.03 0.138 ±0.00 0.151 ±0.00 14.986 ±0.08 2.192 ±0.04
app-medium clean lock-only cache-only modules-only no-lock no-cache no-modules no-clean show-version run-script cache-only
peer-deps
no-clean
audit
npm@latest 29.656 ±1.37 8.037 ±0.01 8.949 ±0.09 1.530 ±0.00 1.496 ±0.01 1.430 ±0.03 5.846 ±0.03 1.331 ±0.01 0.140 ±0.00 0.167 ±0.00 10.123 ±0.15 2.018 ±0.01
#7574 28.983 ±1.74 8.102 ±0.02 9.472 ±0.05 1.610 ±0.02 1.595 ±0.06 1.480 ±0.06 5.885 ±0.01 1.329 ±0.01 0.130 ±0.00 0.155 ±0.00 10.141 ±0.25 2.104 ±0.05

@wraithgar wraithgar merged commit 15be6dd into latest May 30, 2024
42 checks passed
@wraithgar wraithgar deleted the gar/config-perf-tweak branch May 30, 2024 15:50
@github-actions github-actions bot mentioned this pull request May 30, 2024
@Foxsenrubas

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants