Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: remove old audit fallback request #7911

Merged
merged 3 commits into from
Nov 20, 2024
Merged

fix!: remove old audit fallback request #7911

merged 3 commits into from
Nov 20, 2024

Commits on Nov 20, 2024

  1. fix!: remove old audit fallback request 

    BREAKING CHANGE: npm will no longer fall back to the old audit endpoint
if the bulk advisory request fails.

This legacy code has a long tail in npm.  Getting rid of it was
difficult because of how load-bearing some of those requests were in
tests.  This PR removes the old "mock server" that arborist tests spun
up, and moved that logic into the existing mock registry that the cli
uses.  This will allow us to consolidate our logic in tests, and also
outline more granularly which tests actually make registry requests.

A few tests that were testing just the fallback behavior were also
removed.
    @wraithgar
    wraithgar committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    2b3ee8b View commit details
    Browse the repository at this point in the history

  2. chore: fix cli tests for audit fallback removal

    @wraithgar
    wraithgar committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    558bc9b View commit details
    Browse the repository at this point in the history

  3. chore: fix dependencies script for circular workspace deps

    @wraithgar
    wraithgar committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    8f91e46 View commit details
    Browse the repository at this point in the history