fix: correctly handle error events that happen after response events #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
approved these changes
Jul 1, 2021
nlf
force-pushed
the
nlf/forward-request-errors
branch
5 times, most recently
from
72a6096 to
7daaa51
Compare
nlf
force-pushed
the
nlf/forward-request-errors
branch
from
5534dbe to
a3b722c
Compare
this is due to the lack of brotli support, which we cannot cover without mocking an entire brotli stream, which is far outside the scope of reason PR-URL: #14 Credit: @nlf Close: #14 Reviewed-by: @wraithgar
nlf
force-pushed
the
nlf/forward-request-errors
branch
from
a3b722c to
9c1c80b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i wrote a pretty long comment in the code to be sure that the error propagation never gets accidentally removed, and we remember to account for this situation when we eventually refactor this.
this resolves a lot of the
cb() never callederrors, especially those in Windows where i was able to reproduce the bug pretty easily. i suspect there's a similar issue in other operating systems, but was unable to prove it. similarly testing this proved somewhat difficult since the underlying request object is inaccessible from the response object the promise resolves to, so there isn't an easy way to manually trigger this problem.this code is definitely due some refactoring, and as part of that it would be nice to allow access to the raw request and response objects so that we can test this accurately, but that work should not delay getting this fix released.