fix: reject with error from parent context on close

[lukekarrys]

This PR does two things:

• When the spawned process is closed with a code or signal, it rejects with an error from the parent context to preserve that more useful stack trace
• Changes the error message from command failed to @npmcli/promise-spawn command failed. I feel like command failed looks too generic when thrown in the context of the npm CLI and this makes it clear that the error came from spawning something. I removed this from the PR since it could be a breaking change since npm looks for this error message. It would be better to give this a better message further up the stack.

It also refactors a bit to remove one level of nesting. It uses the Promise.withResolvers() pattern to hoist the resolve and reject functions since none of the work actually needs to be done within the Promise executor.

Example

Here's a before and after of npm rebuild --loglevel verbose of a failing preinstall script. Some output is removed for clarity/brevity.

before

npm verb title npm rebuild
npm verb argv "rebuild" "--loglevel" "verbose"
npm info run [email protected] preinstall  bash ./my-preinstall-script.sh
npm info run [email protected] preinstall { code: 1, signal: null }
npm verb stack Error: command failed
npm verb stack     at ChildProcess.<anonymous> (/Users/lukekarrys/Desktop/npm-debug/.versions/npm-10.5.2/node_modules/@npmcli/promise-spawn/lib/index.js:53:27)
npm verb stack     at ChildProcess.emit (node:events:518:28)
npm verb stack     at maybeClose (node:internal/child_process:1105:16)
npm verb stack     at Socket.<anonymous> (node:internal/child_process:457:11)
npm verb stack     at Socket.emit (node:events:518:28)
npm verb stack     at Pipe.<anonymous> (node:net:337:12)
npm verb pkgid [email protected]
npm ERR! code 1
npm ERR! path /Users/lukekarrys/Desktop/npm-debug/debug-init-cancel
npm ERR! command failed
npm ERR! command sh -c bash ./my-preinstall-script.sh
npm ERR! Somes script output
npm ERR! Oh no, this will error!
npm verb exit 1
npm verb code 1

after

npm verb title npm rebuild
npm verb argv "rebuild" "--loglevel" "verbose"
npm info run [email protected] preinstall  bash ./my-preinstall-script.sh
npm info run [email protected] preinstall { code: 1, signal: null }
npm verb stack Error: command failed
npm verb stack     at promiseSpawn (/Users/lukekarrys/projects/npm/cli/node_modules/@npmcli/promise-spawn/lib/index.js:22:22)
npm verb stack     at spawnWithShell (/Users/lukekarrys/projects/npm/cli/node_modules/@npmcli/promise-spawn/lib/index.js:124:10)
npm verb stack     at promiseSpawn (/Users/lukekarrys/projects/npm/cli/node_modules/@npmcli/promise-spawn/lib/index.js:12:12)
npm verb stack     at runScriptPkg (/Users/lukekarrys/projects/npm/cli/node_modules/@npmcli/run-script/lib/run-script-pkg.js:75:13)
npm verb stack     at runScript (/Users/lukekarrys/projects/npm/cli/node_modules/@npmcli/run-script/lib/run-script.js:9:12)
npm verb stack     at /Users/lukekarrys/projects/npm/cli/workspaces/arborist/lib/arborist/rebuild.js:333:17
npm verb stack     at run (/Users/lukekarrys/projects/npm/cli/node_modules/promise-call-limit/dist/commonjs/index.js:67:22)
npm verb stack     at /Users/lukekarrys/projects/npm/cli/node_modules/promise-call-limit/dist/commonjs/index.js:84:9
npm verb stack     at new Promise (<anonymous>)
npm verb stack     at callLimit (/Users/lukekarrys/projects/npm/cli/node_modules/promise-call-limit/dist/commonjs/index.js:35:69)
npm verb pkgid [email protected]
npm ERR! code 1
npm ERR! path /Users/lukekarrys/Desktop/npm-debug/debug-init-cancel
npm ERR! command failed
npm ERR! command sh -c bash ./my-preinstall-script.sh
npm ERR! Some script output
npm ERR! Oh no, this will error!
npm verb exit 1
npm verb code 1

[wraithgar]

Everything looks good here, I get why we're doing it, but it still makes me nervous in light of things like npm/run-script#188. Let's be extra wary of new issues we didn't expect.