Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weasis uses PatientPseudoUID to compare different patients #26

Merged
merged 7 commits into from
Dec 22, 2017

Conversation

felipefetzer
Copy link
Contributor

This new method creates a new way to compare these patients.
You can use a property (patientComparator.buildPatientPseudoUID) to use
just the fields you want.

For example:
If you want to create a PatientPseudoUID just with name and patientID,
you add the following property -> patientComparator.buildPatientPseudoUID=patientId,patientName
(divided by comma)

However, if you prefer, you do not need to use this property,
and you can keep using the normal way to create the PatientPseudoUID.

--

About the Java modification:
I created a new class that center the Patient comparation;
I deleted the old buildPatientPseudoUID in DicomMediaUtils;
And I modified all the old calls - from DicomMediaUtils.buildPatientPseudoUID to PatientComparator.buildPatientPseudoUID

felipefetzer and others added 7 commits December 18, 2017 16:26
Weasis uses PatientPseudoUID to compare different patients. This new method creates a new way to compare these patients. You can use a property (patientComparator.buildPatientPseudoUID) to use just the fields you want. 

For example:
If you want to create a PatientPseudoUID just with name and patientID, you add the following property -> patientComparator.buildPatientPseudoUID=patientId,patientName (divided by comma)

However, if you prefer, you do not need to use this property, and you can keep using the normal way to create the PatientPseudoUID.
This new method creates a new way to compare these patients. 
You can use a property (patientComparator.buildPatientPseudoUID) to use 
just the fields you want. 

For example:
If you want to create a PatientPseudoUID just with name and patientID, 
you add the following property -> patientComparator.buildPatientPseudoUID=patientId,patientName 
(divided by comma)

However, if you prefer, you do not need to use this property, 
and you can keep using the normal way to create the PatientPseudoUID.
# Conflicts:
#	weasis-dicom/weasis-dicom-codec/src/main/java/org/weasis/dicom/codec/utils/DicomMediaUtils.java
#	weasis-dicom/weasis-dicom-codec/src/main/java/org/weasis/dicom/codec/utils/PatientComparator.java
The field ID was removed; 
Modification in buildPatientPseudoUID;
@nroduit nroduit merged commit 91fd5e1 into nroduit:master Dec 22, 2017
@nroduit
Copy link
Owner

nroduit commented Dec 22, 2017

Be careful with PatientPseudoUID because this UID is a key in the DICOM model (cannot be changed or updated). There is now a merge strategy in some cases, see f346618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants