Skip to content

Commit

Permalink
chore(app): allow user to define/override MQ volumes
Browse files Browse the repository at this point in the history
With the incoming switch to artemis, we need to be able to override these
values until we do chart 1.0. This should work well enough for us until
that point.
  • Loading branch information
stevepentland committed Aug 20, 2024
1 parent 4aefce1 commit 80ce7e5
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 5 deletions.
2 changes: 1 addition & 1 deletion charts/nx-cloud/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: nx-cloud
description: Nx Cloud Helm Chart
type: application
version: 0.15.8
version: 0.15.9
maintainers:
- name: nx
url: "https://nx.app/"
Expand Down
17 changes: 13 additions & 4 deletions charts/nx-cloud/templates/nx-cloud-message-queue-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,11 @@ spec:
resources: {{- toYaml .Values.messagequeue.resources | nindent 12 }}
{{- end }}
env:
- name: ACTIVEMQ_TMP
value: /opt/activemq/tmp
{{- if .Values.messagequeue.deployment.env }}
{{- toYaml .Values.messagequeue.deployment.env | nindent 12 }}
{{- else }}
- name: ACTIVEMQ_TMP
value: /opt/activemq/tmp
{{- end }}
ports:
- containerPort: {{ .Values.messagequeue.deployment.port }}
Expand All @@ -39,13 +40,21 @@ spec:
{{- toYaml .Values.messagequeue.securityContext | nindent 12 }}
{{- end }}
volumeMounts:
{{- if .Values.messagequeue.deployment.volumeMounts }}
{{- toYaml .Values.messagequeue.deployment.volumeMounts | nindent 12 }}
{{- else }}
- mountPath: /opt/activemq/data
name: data
- mountPath: /opt/activemq/tmp
name: tmp
{{- end }}
volumes:
- emptyDir: {}
{{- if .Values.messagequeue.deployment.volumes }}
{{- toYaml .Values.messagequeue.deployment.volumes | nindent 8 }}
{{- else }}
- emptyDir: { }
name: data
- emptyDir: {}
- emptyDir: { }
name: tmp
{{- end }}
{{- end }}
2 changes: 2 additions & 0 deletions charts/nx-cloud/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ messagequeue:
deployment:
port: 61616
env: []
volumes: { }

Check failure on line 123 in charts/nx-cloud/values.yaml

View workflow job for this annotation

GitHub Actions / lint-and-test

123:15 [braces] too many spaces inside empty braces
volumeMounts: { }

Check failure on line 124 in charts/nx-cloud/values.yaml

View workflow job for this annotation

GitHub Actions / lint-and-test

124:20 [braces] too many spaces inside empty braces
service:
name: nx-cloud-messagequeue
type: ClusterIP
Expand Down

0 comments on commit 80ce7e5

Please sign in to comment.