Skip to content

Commit

Permalink
fix(rspack): update required stubs
Browse files Browse the repository at this point in the history
  • Loading branch information
Coly010 committed Nov 5, 2024
1 parent 1cb4517 commit bd230b3
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 1 addition & 0 deletions packages/rspack/src/plugins/utils/models.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ export interface NxAppRspackPluginOptions {
* The compiler to use. Default is `babel` and requires a `.babelrc` file.
*/
compiler?: 'babel' | 'swc' | 'tsc';
// TODO: Check if this is supportable in rspack. It was only being used in the WriteIndexHtmlPlugin for Webpack. The same isn't supported in HtmlRspackPlugin.
/**
* Set `crossorigin` attribute on the `script` and `link` tags.
*/
Expand Down
3 changes: 0 additions & 3 deletions packages/rspack/src/utils/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,7 @@ function ensureNxRspackExecutionContext(ctx: NxRspackExecutionContext): void {
sourceRoot: projectNode.data.sourceRoot ?? projectNode.data.root,
// These aren't actually needed since NxRspackPlugin and withNx both support them being undefined.
assets: undefined,
outputPath: undefined,
tsConfig: undefined,
outputFileName: undefined,
main: undefined,
rspackConfig: undefined,
};
ctx.context ??= {
Expand Down

0 comments on commit bd230b3

Please sign in to comment.