-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@nx/cypress:cypress executor hanging since v20.3.0 #29571
Comments
We also see a suspicious looking "25h" printed in the logs in some of our projects, the ones which use @nx/cypress/plugin or the @nx/cypress:cypress directly. |
I can confirm this is also happening to us. We're using nx-cloud and distributed task execution an each of the agents after it completes a cypress task hangs. It also seems isolated to the @nx/cypress executor. If we bypass this executor and instead call the cypress cli directly, we do not have this issue. |
Hi @PodStuart / @nsmith7989, I've put together a test repo on 20.3.1 to try and reproduce, but so far, I have had no luck. The e2e tests seem to complete without issue. Is there anything you can think of that differs from the defaults here that we can try to add to reproduce the issue? |
@llwt / @PodStuart I was able to create a reproduction that mostly mimics our setup. Action run that shows the issue I forked from @llwt's repo above and kept adding items until it was closer to our setup.
Note the other nextjs application in this repo does not have a custom server and does not have this issue. |
This does not seem to have anything to do with DTE, I've made a branch that reproduces the issue by only running e2e with the cyrpess executor I did a bit more digging in an attempt to "bisect" when this was added using the 20.3.0-beta.x releases 20.3.0-beta.0Dec 10, 2024 Action: https://github.com/nsmith7989/nx-20-3-1/actions/runs/12840012589/job/35808076596 Result: ✅ 20.3.0-beta.1Dec 17, 2024 Result: ❌ More granular with Canary 20.3.0-canary.20241214-4cd640aDec 14, 2024 Result: ✅ 20.3.0-canary.20241217-ee4de0bDec 17, 2024 Result: ❌ TL;DR it looks like this issue was introduced between |
Thanks @llwt / @nsmith7989 good to know it is not just us :) From our setup I can confirm we are not using Nx cloud and the hang does not occur when using nx affected, which we use earlier in the pipeline to determine which e2e tests to run and then feed into a GitHub actions matrix running the e2e target directly. We are also not using inferred tasks. We also have quite a variety of configurations in our repository and the issue impacts them all, even one which is essentially a "hello world", a new e2e projects to which tests have not yet been added. I'll attach that for good measure. The issue is still present on 20.3.2 (just checked) and we have only seen it on GitHub actions (ubuntu-22.04), and not locally. |
…29689) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Running an e2e task using the `@nx/cypress:cypress` executor that starts a dev server by running another task that uses the `@nx/js:node` executor result in the process to hang after the e2e tests have finished running. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> The async generator returned by starting the dev server and consumed by the `@nx/cypress:cypress` executor should be finished, and the `@nx/js:node` executor should properly clean up its child process once the generator is finished. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #29571
Current Behavior
Our e2e tests using the @nx/cypress:cypress executor have started to hang since the upgrade to v20.3.0.
We see "All specs passed!" in the output then the process hangs before being killed by GitHub Actions owing to the timeout being breached.
Wondering if anyone else has seen this.
Expected Behavior
Our e2e tests run as before.
GitHub Repo
No response
Steps to Reproduce
Not really sure how to create a minimal example to reproduce the issue.
Nx Report
Failure Logs
Package Manager Version
No response
Operating System
Additional Information
No response
The text was updated successfully, but these errors were encountered: