-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nx-dev): update top-level navbar #29003
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 51d5eb8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
71abe51
to
e19a25e
Compare
variant: 'primary', | ||
size: 'small', | ||
title: 'Try Nx Cloud for free', | ||
children: 'Try Nx Cloud for free', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
children: 'Try Nx Cloud for free', | |
children: <>Try Nx Cloud for free</>, |
} from './menu-items'; | ||
import { MobileMenuItem } from './mobile-menu-item'; | ||
import { SectionsMenu } from './sections-menu'; | ||
import { TwoColumnsMenu } from './two-columns-menu'; | ||
import { AlgoliaSearch } from '@nx/nx-dev/feature-search'; | ||
import { GitHubIcon, NxCloudAnimatedIcon, NxIcon } from '@nx/nx-dev/ui-icons'; | ||
|
||
export function Header(): JSX.Element { | ||
// Add props interface at the top of the file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can get rid of this comment.
ctaButtons?: ButtonLinkProps[]; | ||
} | ||
|
||
// Update the component signature to accept props |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can get rid of this comment.
@@ -42,6 +49,20 @@ export function Header(): JSX.Element { | |||
}; | |||
}, []); | |||
|
|||
// Default CTA buttons configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can get rid of this comment.
// 'Use cases': useCaseItems | ||
}; | ||
export const resourceMenuItems = { | ||
Learn: learnItems, | ||
Events: eventItems, | ||
Company: companyItems, | ||
}; | ||
|
||
// Add new sections for enterprise resources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can get rid of this comment.
}, | ||
]; | ||
|
||
// Add the new menu sections |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can get rid of this comment.
4a2bc3f
to
e883246
Compare
e883246
to
51d5eb8
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Updates the nx-dev top-level navigation bar