Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx-dev): update top-level navbar #29003

Merged
merged 1 commit into from
Nov 25, 2024
Merged

feat(nx-dev): update top-level navbar #29003

merged 1 commit into from
Nov 25, 2024

Conversation

juristr
Copy link
Member

@juristr juristr commented Nov 20, 2024

Updates the nx-dev top-level navigation bar

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Nov 25, 2024 8:34pm

variant: 'primary',
size: 'small',
title: 'Try Nx Cloud for free',
children: 'Try Nx Cloud for free',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
children: 'Try Nx Cloud for free',
children: <>Try Nx Cloud for free</>,

} from './menu-items';
import { MobileMenuItem } from './mobile-menu-item';
import { SectionsMenu } from './sections-menu';
import { TwoColumnsMenu } from './two-columns-menu';
import { AlgoliaSearch } from '@nx/nx-dev/feature-search';
import { GitHubIcon, NxCloudAnimatedIcon, NxIcon } from '@nx/nx-dev/ui-icons';

export function Header(): JSX.Element {
// Add props interface at the top of the file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get rid of this comment.

ctaButtons?: ButtonLinkProps[];
}

// Update the component signature to accept props
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get rid of this comment.

@@ -42,6 +49,20 @@ export function Header(): JSX.Element {
};
}, []);

// Default CTA buttons configuration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get rid of this comment.

// 'Use cases': useCaseItems
};
export const resourceMenuItems = {
Learn: learnItems,
Events: eventItems,
Company: companyItems,
};

// Add new sections for enterprise resources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get rid of this comment.

},
];

// Add the new menu sections
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get rid of this comment.

@juristr juristr force-pushed the nxdev/navbar-tests branch 2 times, most recently from 4a2bc3f to e883246 Compare November 25, 2024 20:00
@juristr juristr enabled auto-merge (rebase) November 25, 2024 20:26
@juristr juristr merged commit 9921496 into master Nov 25, 2024
5 of 6 checks passed
@juristr juristr deleted the nxdev/navbar-tests branch November 25, 2024 20:33
Copy link

github-actions bot commented Dec 1, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants