-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(angular): strip trailing slash from directory #9263 #9314
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nrwl/nx-dev/26Pzn6nAvKEHJkAr7NqcSzsVbMXw [Deployment for b56a03a canceled] |
packages/angular/src/generators/library/lib/normalize-options.ts
Outdated
Show resolved
Hide resolved
366f1ee
to
b56a03a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Having a trailing slash in
directory
option is causing an error due to our parsing of it.Expected Behavior
strip off the trailing slash.
Related Issue(s)
Fixes #9263