Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest stable hardforks #3724

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Latest stable hardforks #3724

merged 4 commits into from
Dec 6, 2024

Conversation

roman-khimov
Copy link
Member

Problem

#3719.

Solution

Aquí.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.82%. Comparing base (9a39230) to head (5f09e00).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3724      +/-   ##
==========================================
- Coverage   82.83%   82.82%   -0.02%     
==========================================
  Files         335      335              
  Lines       46846    46847       +1     
==========================================
- Hits        38807    38801       -6     
- Misses       6448     6451       +3     
- Partials     1591     1595       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

docs/node-configuration.md Outdated Show resolved Hide resolved
pkg/core/blockchain.go Outdated Show resolved Hide resolved
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Close #3719 either to the PR description or to the commit message. Otherwise this issue won't be closed automatically after PR merge.

Differentiate released and stable ones from test-only not-yet-ready and such.
Enabled only stable ones by default to avoid surprises in private networks
when some beta hardfork is made available with some node release.

Fixes #3719.

Signed-off-by: Roman Khimov <[email protected]>
Function doesn't make much sense here. The change is rather trivial and this
is not expected to be used by external code, so no deprecation.

Signed-off-by: Roman Khimov <[email protected]>
It's impossible to maintain a 4K line. I'm not even sure new table works good
enough, but at least it's per-hardfork.

Signed-off-by: Roman Khimov <[email protected]>
@AnnaShaleva AnnaShaleva merged commit 2bc41db into master Dec 6, 2024
33 of 34 checks passed
@AnnaShaleva AnnaShaleva deleted the hf-latest-stable branch December 6, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants