-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest stable hardforks #3724
Latest stable hardforks #3724
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3724 +/- ##
==========================================
- Coverage 82.83% 82.82% -0.02%
==========================================
Files 335 335
Lines 46846 46847 +1
==========================================
- Hits 38807 38801 -6
- Misses 6448 6451 +3
- Partials 1591 1595 +4 ☔ View full report in Codecov by Sentry. |
c9aead5
to
88f9257
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Close #3719
either to the PR description or to the commit message. Otherwise this issue won't be closed automatically after PR merge.
Differentiate released and stable ones from test-only not-yet-ready and such. Enabled only stable ones by default to avoid surprises in private networks when some beta hardfork is made available with some node release. Fixes #3719. Signed-off-by: Roman Khimov <[email protected]>
Function doesn't make much sense here. The change is rather trivial and this is not expected to be used by external code, so no deprecation. Signed-off-by: Roman Khimov <[email protected]>
It's impossible to maintain a 4K line. I'm not even sure new table works good enough, but at least it's per-hardfork. Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
977184c
to
5f09e00
Compare
Problem
#3719.
Solution
Aquí.