services: fix defer function in retry of NeoFSBlockFetcher
#3736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drain the channel only if it has pending events. This avoids trying to read from an already-empty channel. Close #3734 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3736 +/- ##
==========================================
- Coverage 82.91% 82.88% -0.03%
==========================================
Files 335 335
Lines 46847 46848 +1
==========================================
- Hits 38841 38831 -10
- Misses 6411 6419 +8
- Partials 1595 1598 +3 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
approved these changes
Dec 9, 2024
| <-timer.C | ||
| select { | ||
| case <-timer.C: | ||
| default: |
AnnaShaleva
added a commit
that referenced
this pull request
Dec 9, 2024
Ref. #3736. Signed-off-by: Anna Shaleva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3734