Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide NNS domain expiration in register #262

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Provide NNS domain expiration in register #262

merged 2 commits into from
Aug 29, 2022

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Aug 23, 2022

Also, close #259 .

@carpawell
Copy link
Member

tests failed?

@fyrchik
[nspcc-dev#259] nns: Check admin in Renew
c0ec1e7 
Signed-off-by: Evgenii Stratonikov <[email protected]>
@fyrchik
Copy link
Contributor Author

fyrchik commented Aug 23, 2022

@carpawell fixed

carpawell
carpawell approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, was it a bug or why did we use constant before?

@fyrchik
Copy link
Contributor Author

fyrchik commented Aug 23, 2022

I asked @KirillovDenis , probably for convenience. It is hard to tell now.

@fyrchik fyrchik merged commit b4fdd85 into nspcc-dev:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carpawell carpawell carpawell approved these changes

@alexvanin alexvanin Awaiting requested review from alexvanin

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider cthulhu-rider is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check admin in Renew
2 participants
@fyrchik @carpawell