common: ignore stale votes in TryPurgeVotes #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a real healthy network we _always_ have something there. Consider seven IRs doing something, we only need five signatures, so they're added and then dropped when we have enough of them, but excessive transactions from the other IRs still come and they will be added again into the same voting structure. But according to the definition of blockDiff we can ignore stale votes safely (they're not counted for votes anyway). Signed-off-by: Roman Khimov <[email protected]>
cthulhu-rider
previously approved these changes
Apr 13, 2023
| @@ -1,6 +1,19 @@ | |||
| # Changelog | |||
| Changelog for NeoFS Contract | |||
|
|
|||
| ## [Unreleased] | |||
There was a problem hiding this comment.
lets actualize diff link for this
0.17.0 link is also missing btw
There was a problem hiding this comment.
Yeah, I've noticed. Though to create another PR, but hey, let's have it here.
Signed-off-by: Roman Khimov <[email protected]>
cthulhu-rider
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a real healthy network we always have something there. Consider seven IRs doing something, we only need five signatures, so they're added and then dropped when we have enough of them, but excessive transactions from the other IRs still come and they will be added again into the same voting structure.
But according to the definition of blockDiff we can ignore stale votes safely (they're not counted for votes anyway).