Contract binary package #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise pkg.go.dev refuses to show anything, see https://pkg.go.dev/license-policy Signed-off-by: Roman Khimov <[email protected]>
Strip the contract name from NEF (it's redundant), make it more clear that
we have a manifest already in JSON ("config" can also refer to "config.yml"
for the compiler).
Signed-off-by: Roman Khimov <[email protected]>
And check for updates in workflow. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
contract-binary-package
branch
4 times, most recently
from
aafb87f to
21ced72
Compare
| func TestGetFS(t *testing.T) { | ||
| c, err := GetFS() | ||
| require.NoError(t, err) | ||
| require.Equal(t, len(fsContracts), len(c)) |
There was a problem hiding this comment.
suggest to also test They're returned in the order they're supposed to be deployed starting from NNS statement from docs. We can also check exact (i guess) result contents since embedded files are now presented in the repo
ok to be done later
Don't pollute contracts go.mod with go-spew and CLI dependencies. Signed-off-by: Roman Khimov <[email protected]>
Signed-off-by: Roman Khimov <[email protected]>
Make them available via a simple package update. Signed-off-by: Roman Khimov <[email protected]>
Real errors are returned like this: "error": "call 'resolve' method of the NNS contract: invocation failed: at instruction 4100 (THROW): unhandled exception: \"token not found\"" So it can't be a simple equality check. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
contract-binary-package
branch
from
21ced72 to
b22d2d7
Compare
cthulhu-rider
approved these changes
Jun 17, 2024
carpawell
added a commit
to carpawell/neofs-dev-env
that referenced
this pull request
Sep 5, 2024
They were changed after nspcc-dev/neofs-contract#401. Signed-off-by: Pavel Karpy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.